Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coar Notify Integration #2681

Merged
merged 263 commits into from
Feb 29, 2024
Merged

Coar Notify Integration #2681

merged 263 commits into from
Feb 29, 2024

Conversation

frabacche
Copy link
Contributor

@frabacche frabacche commented Dec 1, 2023 •
edited
Loading

Description

Quality Assurance Events and LDN Message Protocol.

Based on these old Pull Requests:

Related to new Pull Requests:

Continues on:

Instructions for Reviewers

Technical implementations documented here : https://wiki.lyrasis.org/pages/viewpage.action?pageId=319815713

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Sondissimo and others added 30 commits August 29, 2023 13:42
@Sondissimo
CST-11012 Finalized Coar text +logo
2ba86ed
@Sondissimo
CST-11012 Finalized Coar text +logo (centered with itself)
7676478
@Sondissimo
CST-11012 removed extra comment
07527e1
@Sondissimo
CST-11012 removed not needed path in app-routing-paths.ts
1f5f055
@Sondissimo
CST-11012 removed not needed path in app-routing-paths.ts
18aa0bb
@Sondissimo
CST-11012 needed path in app-routing-paths.ts
eb82628
@Sondissimo
CST-11012 fixed conflicts
f9e4044
@Sondissimo
Merge branch 'coar-notify-7' of bitbucket.org:4Science/dspace-angular…
0d79dd0 
… into CST-11012-demo
Merged in CST-11012-demo (pull request DSpace#778)
9a0f6fd 
CST-11012 demo
@Sondissimo
CST-11048 First commit
24a0af1
@Sondissimo
CST-11048 First commit +fix for admin routing
4805b50
@Sondissimo
CST-11048 sync branch with coar-notify-7
b040f9c
@Sondissimo
CST-11048 FInished the angular implementation for the ldn inbox, need…
1c9fbd4 
…s cleanup
@Sondissimo
CST-11048 Form Styling
11f9258
@Sondissimo
CST-11048 Implemented enabled slider in edit
f893c6f
@Sondissimo
CST-11048 Spaced form updated error behaviour
c75f618
@abollini
Merged in CST-11048 (pull request DSpace#905)
9ab62d2 
CST-11048

Approved-by: Andrea Bollini
CST-10639 Added new fields in the item-view (Endorsed Reviewed and Da…
2bf5653 
…taset)
CST-10639 Fixed fields in the item-view (Endorsed Reviewed and Dataset)
4dd3392
CST-10639 Fixed field in the item-view (Endorsement)
71adb5b
CST-11045 Located component, working on adding new accordion
8f63b54
CST-12174 Coar form pages are now sized correctly, finishing up save …
9216073 
…button and alias for api call
CST-12174 Ldn services are now retrieved with the remotadata object
8de0e76
CST-12174 Implemented data-service for the api calls
1c376b2
CST-12174 added resetForm and leave edit for edit-form and overview page
ba0b110
@alisaismailati
[CST-12235] LDN inbox mechanism for home (partial commit)
6d794cd
CST-12174 created new remotadata service for itemfilters, pages are u…
2eb7160 
…pdated in real time when editing/creating/deleting services related stuff, added modals to confirm/reset
@alisaismailati
[CST-12145] partial commit
318f057
CST-12174 Updated delete services to mark for deletion
5cca15d
CST-12174 Updated delete services to mark for deletion
0963a32
@github-actions GitHub Actions
Copy link

Hi @frabacche,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@github-actions GitHub Actions
Copy link

Hi @frabacche,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@github-actions GitHub Actions
Copy link

Hi @frabacche,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@tdonohue
Copy link
Member

@frabacche or @FrancescoMolinaro : please rebase this so that it no longer has merge conflicts so that it can be tested again. (I just added this same note to the backend PR as well)

@tdonohue
Copy link
Member

@frabacche and @FrancescoMolinaro: I gave this a code review today. It appears all my prior feedback is addressed. However, I'm unable to test or merge this until the merge conflict is resolved.

@tdonohue tdonohue self-requested a review February 29, 2024 14:47
@tdonohue
Copy link
Member

tdonohue commented Feb 29, 2024 •
edited
Loading

@frabacche & @FrancescoMolinaro : I'm still testing this but found a small bug:

If I disable this feature via ldn.enabled = false and start the UI in prod mode (yarn build:prod; yarn serve:ssr), then every page reload results in a minor error in your Browser's DevTools:

ERROR TypeError: You provided 'undefined' where a stream was expected. You can provide an Observable, Promise, ReadableStream, Array, AsyncIterable, or Iterable.
    at t (main.e95be47509bc96ea.js:1:1789880)
    at v (main.e95be47509bc96ea.js:1:1769810)
    at l.subscribe.g (main.e95be47509bc96ea.js:1:1780091)
    at o._next (main.e95be47509bc96ea.js:1:1772359)
    at o.next (main.e95be47509bc96ea.js:1:1761159)
    at main.e95be47509bc96ea.js:1:1776332
    at o._next (main.e95be47509bc96ea.js:1:1772359)
    at o.next (main.e95be47509bc96ea.js:1:1761159)
    at subscribe.h (main.e95be47509bc96ea.js:1:1780127)
    at o._next (main.e95be47509bc96ea.js:1:1772359)

This error can also be found in the SSR logs with a bit more detail:

ERROR TypeError: You provided 'undefined' where a stream was expected. You can provide an Observable, Promise, ReadableStream, Array, AsyncIterable, or Iterable.
    at Object.createInvalidObservableTypeError (C:\dspace-angular\dist\server\main.js:7:1997485)
    at Object.innerFrom (C:\dspace-angular\dist\server\main.js:7:1828015)
    at C:\dspace-angular\dist\server\main.js:7:1920404

It appears to only occur when this feature is disabled. No similar error appears when ldn.enabled = true.

I'm still testing, but wanted to report this immediately. If it turns out to be the only error, I may still approve this & create a bug ticket for you to resolve in the next set of COAR Notify PRs.

tdonohue
tdonohue reviewed Feb 29, 2024
View reviewed changes
src/assets/i18n/en.json5

"mydspace.qa-event-notification.check.notification-info": "There are {{num}} pending review to check",

"mydspace.qa-event-notification-info.check.button": "Check",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 4 keys in a row here that are duplicates. The keys on 6165-6171 can be removed because they already appear in this file.

tdonohue
tdonohue approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @frabacche and @FrancescoMolinaro ! My prior feedback has been addressed. However there are two very minor issues that remain. In order to move this along & free up the other PRs, I'm going to merge this as-is and log a bug ticket to fix the two remaining issues.

The two remaining issues are:

  1. An error occurs when this feature is disabled. See Coar Notify Integration #2681 (comment)
  2. Duplicate i18n keys exist. The ones added by this PR should be removed as they override the changes made in WITHDRAW / REINSTATE requests for an item #2759 . See Coar Notify Integration #2681 (review)

@tdonohue tdonohue merged commit c195175 into DSpace:main Feb 29, 2024
13 checks passed
@tdonohue tdonohue mentioned this pull request Feb 29, 2024
Closed
@tdonohue
Copy link
Member

Added a bug ticket which must be resolved in follow-up work: #2842. Assigned to @frabacche

@tdonohue tdonohue added the integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services label Feb 29, 2024
alexandrevryghem added a commit to alexandrevryghem/dspace-angular that referenced this pull request Feb 29, 2024
@alexandrevryghem
Fixed tests without expectations from DSpace#2759 & DSpace#2681
371e766 
Added the necessary done() calls back & fixed tests
@alexandrevryghem alexandrevryghem mentioned this pull request Feb 29, 2024
Merged
8 tasks
@tdonohue tdonohue mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescoMolinaro FrancescoMolinaro FrancescoMolinaro left review comments

@tdonohue tdonohue tdonohue approved these changes

Assignees

@frabacche frabacche

Labels
high priority integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services new feature
Projects
No open projects
DSpace 8.0 Release
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@frabacche @FrancescoMolinaro @tdonohue @Sondissimo @alisaismailati @abollini @steph-ieffam